Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Smoothing transition while refreshing sponsor icons #3895

Merged
merged 1 commit into from
Apr 14, 2024
Merged

Smoothing transition while refreshing sponsor icons #3895

merged 1 commit into from
Apr 14, 2024

Conversation

haslinghuis
Copy link
Member

@haslinghuis haslinghuis commented Apr 13, 2024 •
edited
Loading

Screencast.from.13-04-24.23.58.01.webm

@haslinghuis haslinghuis added this to the 10.10.0 milestone Apr 13, 2024
@haslinghuis haslinghuis requested a review from blckmn April 13, 2024 21:33
@haslinghuis haslinghuis self-assigned this Apr 13, 2024
@netlify Netlify
Copy link

netlify bot commented Apr 13, 2024 •
edited
Loading

✅ Deploy Preview for origin-betaflight-app ready!

Name Link
🔨 Latest commit 921c7c7
🔍 Latest deploy log https://app.netlify.com/sites/origin-betaflight-app/deploys/661afa33b40e8b0008d56b98
😎 Deploy Preview https://deploy-preview-3895--origin-betaflight-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@haslinghuis haslinghuis requested a review from McGiverGim April 13, 2024 21:35
@github-actions GitHub Actions
Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Linux
Betaflight-Configurator-Android
Betaflight-Configurator-Windows
Betaflight-Configurator-macOS
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@haslinghuis haslinghuis changed the title Fade in and out sponsor icons on refresh Smoothing transition while refreshing sponsor icons Apr 13, 2024
McGiverGim
McGiverGim approved these changes Apr 14, 2024
View reviewed changes
Copy link
Member

@McGiverGim McGiverGim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good to me, maybe it will be prettier doing it from left to right with a little of delay between them, but as is, it's good enough.

@McGiverGim
Copy link
Member

McGiverGim commented Apr 14, 2024 •
edited
Loading

For a next PR: the first time that loads the image, it is not smooth. They appear randomly and all images move until all is loaded. I don't know if we can make some kind of "preload" before using it, or at least give them a fixed width, in this way, they will not move around at least when loading not cached images.

EDIT: if you want to test it, simply open the "developer tools" (in this way the cache is disabled) in the netlify preview.

@haslinghuis haslinghuis merged commit e444fa9 into betaflight:master Apr 14, 2024
11 checks passed
@haslinghuis haslinghuis deleted the fade-sponsor-icons branch April 14, 2024 11:28
chmelevskij pushed a commit to chmelevskij/betaflight-configurator that referenced this pull request Apr 27, 2024
@haslinghuis @chmelevskij
Smoothing transition while refreshing sponsor icons (betaflight#3895)
11bb02c 
Fade in and out sponsor icons on refresh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HThuren HThuren HThuren approved these changes

@sugaarK sugaarK sugaarK approved these changes

@blckmn blckmn blckmn approved these changes

@McGiverGim McGiverGim McGiverGim approved these changes

@asizon asizon Awaiting requested review from asizon

@nerdCopter nerdCopter Awaiting requested review from nerdCopter

Assignees

@haslinghuis haslinghuis

Labels
RN: UI
Projects
Finalizing Firmware 4.5 Release
Status: COMPLETED
Milestone
10.10.0
Development

Successfully merging this pull request may close these issues.
5 participants
@haslinghuis @McGiverGim @blckmn @sugaarK @HThuren